Commit Graph

2261 Commits

Author SHA1 Message Date
Claude 805fdd3525 feat: add periodic version check with soft reconnection
Implements automatic version updates that are transparent to users:

- Checks for new WhatsApp Web version every 6 hours (configurable)
- When new version detected, saves it for next natural reconnection
- Emits 'version.update' event so users can track updates
- No disconnection required - WhatsApp naturally reconnects every 30min-2h
- Cleans up interval when socket closes

Configuration:
```typescript
const sock = await makeWASocketAutoVersion({
    auth: state,
    versionCheckIntervalMs: 6 * 60 * 60 * 1000 // 6 hours (default)
})

sock.ev.on('version.update', ({ currentVersion, newVersion, isCritical }) => {
    console.log(`New version: ${newVersion.join('.')}`)
})
```
2026-01-21 16:51:39 +00:00
Claude 76e080daec feat: add makeWASocketAutoVersion for automatic version fetching
Adds a new async function that automatically fetches the latest
WhatsApp Web version from web.whatsapp.com before connecting.

Usage:
```typescript
// Option 1: Auto-fetch version (recommended)
const sock = await makeWASocketAutoVersion({ auth: state })

// Option 2: Manual version (existing behavior)
const sock = makeWASocket({ auth: state })
```

Benefits:
- No need to update library for version changes
- Automatic fallback to bundled version if fetch fails
- Logged warnings when using fallback
2026-01-21 16:38:46 +00:00
Claude b9a7c2cabc feat: improve version update robustness and frequency
Changes:
- Update frequency: weekly → daily (06:00 UTC)
- Add retry with exponential backoff (3 attempts per source)
- Add multiple source endpoints (sw.js + bootstrap page)
- Add version validation (sanity checks on revision numbers)
- Add fetch timeout to prevent hanging
- Add detailed logging for debugging
- Simplify workflow to only update baileys-version.json

This makes the version update more reliable and responsive
to WhatsApp Web changes.
2026-01-21 16:22:46 +00:00
Claude 8a134d2420 refactor: centralize WhatsApp version to single source of truth
Instead of maintaining the version number in 3 separate files
(baileys-version.json, index.ts, generics.ts), this change makes
baileys-version.json the single source of truth. Other files now
import the version from this JSON file.

This follows the DRY principle and reduces:
- Risk of version inconsistency across files
- Maintenance burden (only 1 file to update)
- PR diff size (3 files → 1 file for version updates)
- Merge conflict probability

Addresses inefficiency found in Baileys PR #2269.
2026-01-21 16:17:14 +00:00
Renato Alcara f59e8cfe8b feat: add automatic CTWA (Click-to-WhatsApp) ads message recovery
feat: add automatic CTWA (Click-to-WhatsApp) ads message recovery
2026-01-21 12:22:41 -03:00
Claude 5a36ae20d4 feat: add automatic CTWA (Click-to-WhatsApp) ads message recovery
Messages from Facebook/Instagram ads (Click-to-WhatsApp) don't arrive on
linked devices because Meta's ads endpoint doesn't encrypt for multi-device.
They arrive as "Message absent from node" placeholders.

This change automatically requests the message from the primary phone via
PDO (Peer Data Operation) when a CTWA placeholder is detected.

Changes:
- Add enableCTWARecovery config option (default: true)
- Trigger requestPlaceholderResend() for "Message absent from node" errors
- Add Prometheus metrics for CTWA recovery tracking
- Add comprehensive unit tests for CTWA recovery functionality

Resolves: https://github.com/WhiskeySockets/Baileys/issues/1723
Resolves: https://github.com/WhiskeySockets/Baileys/issues/1034
2026-01-21 14:56:39 +00:00
Renato Alcara af6f2eede7 feat: normalize inbound JIDs to PN + batch LID/PN lookups + mapping logs
feat: normalize inbound JIDs to PN + batch LID/PN lookups + mapping logs
2026-01-21 01:34:59 -03:00
Claude d968205376 fix: resolve TypeScript errors in merged code
- Add null check for decoded in getLIDsForPNs loop
- Fix jest mock typing in process-message.test.ts
2026-01-21 04:24:09 +00:00
Claude be1f00c5d5 Merge remote-tracking branch 'origin/codex/analyze-pr-2274-for-repository-contribution' into claude/review-pr-undefined-returns-725K7 2026-01-21 04:16:55 +00:00
Renato Alcara 8ef29c7d94 feat: normalize inbound JIDs to PN + batch LID/PN lookups + mapping logs
Motivation
Avoid duplicate contacts when the same user arrives sometimes as a PN and sometimes as a LID.
Ensure that LID↔PN mappings acquired via history and event synchronization are used immediately.
Improved performance and scalability with batch searches (inspired by PR #2274).

Description
Incoming JID normalization: added normalizeMessageJids to convert remoteJid/participant LID → PN when available, keeping LID as fallback if PN does not already exist.
Batch lookups: getLIDsForPNs and getPNsForLIDs now use batch DB, bidirectional caching, and fallback to USync, reducing individual calls.
Automatic hydration: lidPnMappings from history sync are persisted in the store so that future LID messages are resolved immediately.
Fallback logs: logs detail when LID→PN resolves and when new mappings are stored (history sync and lid-mapping.update).

Tests
Added tests for batch PN→LID, batch LID→PN, and LID→PN normalization fallback.

 Changes applied
Summary
Added batch tests for PN→LID and LID→PN resolution 
Added tests for normalizeMessageJids cobrindo sucesso e fallback (LID permanece quando PN não existe).
2026-01-21 01:12:50 -03:00
Renato Alcara 1c17ecf2ec test: cover lid batch and jid normalization 2026-01-21 01:07:03 -03:00
Renato Alcara 31fdfa8b7c chore: log fallback mapping availability 2026-01-21 00:52:17 -03:00
Claude 9454a824d9 feat(upstream): add comprehensive LID-PN mapping extraction for Baileys PR
This folder contains the files ready for upstream WhiskeySockets/Baileys PR:

Changes to src/Utils/history.ts:
- Add isPersonJid() helper to validate JID types for mapping eligibility
- Add extractLidPnFromConversation() for conversation-level mapping extraction
- Add extractLidPnFromMessage() for message-level mapping extraction
- Modify processHistoryMessage() to extract from 3 sources with deduplication
- Fix validation bug: use || (OR) instead of && (AND) to prevent poisoned mappings

Changes to src/__tests__/Utils/history.test.ts:
- 55 comprehensive tests covering all new functions and edge cases
- Tests for all JID formats (@lid, @hosted.lid, @s.whatsapp.net, @hosted)
- Tests for skipped JIDs (@g.us, @broadcast, @newsletter)
- Tests for bug fix validation (person + group, person + broadcast, etc.)
- Tests for deduplication across all three sources

Related issues:
- Closes WhiskeySockets/Baileys#2282
- Partially addresses WhiskeySockets/Baileys#2281
2026-01-21 01:35:20 +00:00
Renato Alcara 34ab791dc0 fix(history): use OR instead of AND for JID validation in extractLidP…
fix(history): use OR instead of AND for JID validation in extractLidP…
2026-01-20 20:27:35 -03:00
Claude 3e8c89d7d0 fix: resolve merge conflicts from master
Merge master branch and resolve conflicts:
- Use import from '../WABinary/index.js' (master convention)
- Keep the bug fix: || instead of && in extractLidPnFromMessage
- Combine comprehensive tests from both branches
- Use Map for deduplication (master implementation)

All 55 tests passing.
2026-01-20 23:22:45 +00:00
Renato Alcara 02033e7a72 feat(history): comprehensive LID-PN mapping extraction with full JID format support
feat(history): comprehensive LID-PN mapping extraction with full JID format support
2026-01-20 20:17:38 -03:00
Claude 8f3660a099 fix(history): use OR instead of AND for JID validation in extractLidPnFromMessage
Address PR #20 code review feedback:

- Fix logical bug: changed `&&` to `||` in isPersonJid validation
  This ensures BOTH JIDs must be person JIDs before extracting
  a LID-PN mapping, preventing "poisoned" mappings where one side
  is a group/newsletter/broadcast

- Add isPersonJid() helper to validate JID types

- Add extractLidPnFromConversation() to extract mappings from
  conversation lidJid/pnJid properties

- Add extractLidPnFromMessage() to extract mappings from message
  remoteJidAlt/participantAlt fields

- Update processHistoryMessage() to use new extraction functions

- Add comprehensive tests covering edge cases for mixed JID types
  (person + group, person + broadcast, person + newsletter)

Note: Returning `undefined` is the correct TypeScript convention
for indicating absence of value (as per TypeScript team guidelines)
2026-01-20 23:04:49 +00:00
Claude 154dd772dd feat(history): comprehensive LID-PN mapping with full JID format support
Enhances LID-PN mapping extraction to handle all WhatsApp JID formats
and extract mappings from multiple sources within history sync data.

New JID validation:
- Add `isPersonJid()` helper to identify JIDs that can have LID-PN mappings
- Skip non-person JIDs: @newsletter (channels), @broadcast, @g.us (groups)

Triple-source extraction:
1. Top-level `phoneNumberToLidMappings` array (existing)
2. Conversation objects via `lidJid`/`pnJid` properties (existing)
3. Message objects via `remoteJidAlt`/`participantAlt` fields (NEW)

New `extractLidPnFromMessage()` function:
- Extracts mappings from message key alternative JID fields
- Handles both direct messages (remoteJidAlt) and group messages (participantAlt)
- Properly identifies LID vs PN based on server type

JID formats handled:
- @s.whatsapp.net - Standard phone number
- @lid - Logical ID (privacy)
- @hosted - Hosted phone number
- @hosted.lid - Hosted LID

46 comprehensive tests covering all scenarios.

Related: WhiskeySockets/Baileys#2263
2026-01-20 22:29:36 +00:00
Claude 86c1cf439a feat(history): extract LID-PN mappings from conversation objects
WhatsApp provides LID-PN mappings in two locations within history sync:
1. Top-level `phoneNumberToLidMappings` array (already processed)
2. Individual conversation objects with `lidJid`/`pnJid` properties (new)

This change adds extraction from conversation objects, ensuring maximum
mapping coverage regardless of sync type or payload structure.

Key improvements:
- Add `extractLidPnFromConversation()` function with comprehensive JSDoc
- Use Map for O(1) deduplication of mappings across both sources
- Handle all JID formats: @lid, @hosted.lid, @s.whatsapp.net, @hosted
- Normalize JIDs using `jidNormalizedUser()` for consistency
- Skip group chats (@g.us) that don't have LID-PN mappings

Includes 22 comprehensive tests covering:
- LID chat with pnJid extraction
- PN chat with lidJid extraction
- Hosted format handling
- Deduplication between sources
- Edge cases (nulls, groups, missing data)
- All conversation sync types

Related: WhiskeySockets/Baileys#2263
See-also: WhiskeySockets/Baileys#2282
2026-01-20 22:17:09 +00:00
Renato Alcara cc4c918e1a feat(logger): add [BAILEYS] console-friendly logging functions
feat(logger): add [BAILEYS] console-friendly logging functions
2026-01-20 18:47:08 -03:00
Claude bb73662e8f fix(logger): address PR #19 code review feedback
Fixes:
- Remove unused import logBufferMetrics from event-buffer.ts
- Add safeStringify() for robust data formatting:
  - Handles circular references gracefully
  - Formats Error objects properly
  - Truncates large arrays [Array(n)]
  - Handles undefined/null/Date/BigInt values
- Add getMode() method to AdaptiveTimeoutCalculator to avoid
  duplicating mode calculation logic in flush()
- Fix empty data object handling (no trailing space)

Tests:
- Add comprehensive test suite (39 tests) covering:
  - Environment variable check (BAILEYS_LOG=false)
  - All logging functions with emoji verification
  - Session name handling
  - formatLogData edge cases (circular, Error, arrays, etc.)
2026-01-20 21:44:08 +00:00
Claude 3f2ced4501 feat(logger): add [BAILEYS] console-friendly logging functions
Add formatted logging functions with [BAILEYS] prefix and emojis:
- logEventBuffer: buffer events (📦, 🔄, ⚠️, , 🧹, 🧠)
- logBufferMetrics: metrics display (📊)
- logMessageSent/Received: message events (📤, 📥)
- logConnection: connection events (🔌, , 🔴, 🔄, )
- logAuth: authentication events (📱, 🔑, 🚪, 🔐)
- logCircuitBreaker: circuit breaker state (, , 🔶)
- logRetry: retry attempts (🔁)
- logInfo/Warn/Error: generic messages (ℹ️, ⚠️, )
- logLidMapping: LID store events (🗂️, 🔍, 💾, 📦)

All functions respect BAILEYS_LOG=false environment variable.
Integrated into event-buffer.ts and messages-send/recv.ts.
2026-01-20 20:48:46 +00:00
Renato Alcara 88b965c603 feat(logger): add comprehensive environment variable configuration
feat(logger): add comprehensive environment variable configuration
2026-01-20 17:32:36 -03:00
Renato Alcara 44fb5997a1 fix(logger): avoid pino-pretty dependency 2026-01-20 17:30:55 -03:00
Claude a462440c5c feat(logger): add comprehensive environment variable configuration
Support all logging-related environment variables:
- BAILEYS_LOG: Enable/disable logging (default: true)
- BAILEYS_LOG_LEVEL: Set log level (default: info)
- USE_STRUCTURED_LOGS: Enable structured logging (default: false)
- LOG_FORMAT: Output format - 'json' or 'pretty' (default: auto)
- LOGGER_INFO/WARN/ERROR: Enable specific log levels (default: true)

Added createFilteredLogger for level-specific filtering and
createSilentLogger for disabled logging mode.
2026-01-20 20:16:58 +00:00
Renato Alcara 68fd02b924 fix(metrics,retry): gold standard code review corrections
fix(metrics,retry): gold standard code review corrections
2026-01-20 17:06:50 -03:00
Claude 5449e3f70a fix(metrics): handle malformed URLs gracefully in metrics endpoint
Wrap URL parsing in try/catch to prevent server crashes from malformed
requests (invalid percent-encoding, problematic Host headers, etc.).
Returns 400 Bad Request instead of crashing the process.
2026-01-20 19:48:28 +00:00
Claude 6f057b8895 fix(metrics,retry): address gold standard code review
Prometheus Metrics:
- Add METRICS_LABELS fallback for defaultLabels env config
- Separate includeSystem from collectDefaultMetrics with own env var
- Parse URL in /metrics endpoint to support querystrings and trailing slashes
- Sort keys in labelsToKey for stable/deterministic lookups
- Update documentation with all environment variables

Retry Utils:
- Remove abort listener on sleep completion to prevent memory leak
- Apply maxDelay cap AFTER jitter to guarantee max delay limit
- Validate/normalize attempt parameter in calculateDelay
- Count retries only when attempt > 1 (actual retry, not first try)
- Use metrics.retryExhausted instead of generic errors for exhausted retries

Tests:
- Add consistency tests to verify retryConfigs.rsocket matches constants
2026-01-20 19:37:19 +00:00
Renato Alcara 733bede071 Merge pull request #16
fix(metrics): fix configureRegistry call signature
2026-01-20 11:49:53 -03:00
Claude 1944645556 fix(metrics): fix configureRegistry call signature
Update configureRegistry call to match new signature that accepts
only defaultLabels parameter instead of config object.
2026-01-20 14:44:53 +00:00
Renato Alcara 97b58bc011 fix(retry): resolve RETRY_BACKOFF_DELAYS initialization order error
fix(retry): resolve RETRY_BACKOFF_DELAYS initialization order error
2026-01-20 11:36:32 -03:00
Claude baf9123d0c fix(retry): address PR #15 code review feedback
- Re-export RETRY_BACKOFF_DELAYS and RETRY_JITTER_FACTOR from Defaults
  for backwards compatibility with existing imports
- Add 'as const' to RETRY_JITTER_FACTOR for type consistency
- Improve documentation explaining why values are hardcoded in retryConfigs
  (ESM initialization order issues with indirect circular imports)
2026-01-20 14:34:47 +00:00
Claude 890a80da48 fix(retry): use literal values in retryConfigs to fix ESM initialization
Hardcode values in retryConfigs.rsocket instead of referencing
RETRY_BACKOFF_DELAYS and RETRY_JITTER_FACTOR to avoid
"Cannot access before initialization" error in ESM module loading.
2026-01-20 14:25:56 +00:00
Claude cf979d6b6d fix(retry): resolve RETRY_BACKOFF_DELAYS initialization order error
- Remove duplicate RETRY_BACKOFF_DELAYS and RETRY_JITTER_FACTOR from Defaults/index.ts
- Export constants from retry-utils.ts as single source of truth
- Add 'as const' for better type inference
- Fixes "Cannot access 'RETRY_BACKOFF_DELAYS' before initialization" error
2026-01-20 14:17:18 +00:00
Renato Alcara aeec88803d Merge pull request #14
Merge pull request #14
2026-01-20 10:48:31 -03:00
Claude 37fdce4bf3 fix(metrics): address PR #14 code review feedback
- Add registryConfigured flag to ensure single execution of configureRegistry
- Fix race condition by moving setMetricPrefix/configureRegistry before Promise
- Remove unused prefix parameter from configureRegistry function
- Consolidate prefix to single source of truth (configuredPrefix global)
- Allow clearing default labels by passing empty object
- Add resetMetricsConfiguration() and getConfiguredPrefix() for testing
2026-01-20 13:45:26 +00:00
Renato Alcara 20e0efb1f7 fix(retry): address PR #12 code review feedback
fix(retry): address PR #12 code review feedback
2026-01-20 10:35:08 -03:00
Claude 6a0fefc8fe chore: resolve merge conflicts with master
Accept master version which includes:
- prom-client integration fixes from PR #11
- Retry utils improvements from PR #12
2026-01-20 13:34:14 +00:00
Claude af4563ee6a Merge remote-tracking branch 'origin/master' into claude/prom-client-nglwZ 2026-01-20 13:27:02 +00:00
Claude 82dce29dbd fix(metrics): address PR #13 code review feedback
- Apply configured prefix to all metric names via getFullMetricName()
- Configure customRegistry with defaultLabels at initialization
- Prevent memory leak: collectDefaultMetrics only called once via flag
- collectDefaultMetrics now uses customRegistry instead of global
- Initialize prefix/defaultLabels before creating baileysMetrics

All metrics now properly include prefix (e.g., baileys_connection_attempts)
and inherit defaultLabels configured via environment variables.
2026-01-20 13:25:21 +00:00
Renato Alcara 168de69e73 fix(metrics): address PR #11 code review feedback
fix(metrics): address PR #11 code review feedback
2026-01-20 10:20:18 -03:00
Claude 4924912f85 fix(metrics): address PR #11 code review feedback
Major improvements to prometheus-metrics.ts:
- Use custom registry instead of global promClient.register (isolation)
- Remove duplicate localValues - prom-client is now single source of truth
- Fix reset(labels) to respect labels param using remove() instead of reset()
- Migrate Summary class to use prom-client internally
- getMetricsOutput() now uses customRegistry for proper isolation

Fix misleading comments in retry-utils.ts:
- Change "exponential backoff" to "custom progressive backoff"
- Fix comment claiming constants are "from Defaults" (now local)

Breaking changes to getValues()/get() - now async as they query prom-client
2026-01-20 13:16:43 +00:00
Renato Alcara 833d6b14af b719349 fix(retry): address PR #12 code review feedback
b719349 fix(retry): address PR #12 code review feedback
2026-01-20 10:12:03 -03:00
Claude b719349c57 fix(retry): address PR #12 code review feedback
- Add 'stepped' backoff strategy that uses RETRY_BACKOFF_DELAYS directly
- Update rsocket config to use 'stepped' instead of 'exponential'
- Clarify maxWebSocketListeners calculation (8 core + 10 dynamic + 2 buffer)
- Document maxSocketClientListeners calculation (20 core + 20 dynamic + 10 buffer)
- Change 'exponential backoff' to 'custom progressive backoff' in docs
- Add comprehensive tests for getRetryDelayWithJitter and getAllRetryDelaysWithJitter
- Fix existing test type errors (onRetry mock, always/never predicates)
2026-01-20 13:05:13 +00:00
Renato Alcara b21847addb Merge branch 'WhiskeySockets:master' into master 2026-01-20 09:58:02 -03:00
Claude 2d84da8bd7 fix(retry): resolve circular dependency with Defaults module
Define RETRY_BACKOFF_DELAYS and RETRY_JITTER_FACTOR locally in
retry-utils.ts to avoid circular dependency that caused
"Cannot access 'RETRY_BACKOFF_DELAYS' before initialization" error.
2026-01-20 12:37:18 +00:00
Claude 43ece09fe9 feat(metrics): integrate prom-client for native Prometheus support
- Add prom-client ^15.1.3 as production dependency
- Migrate Counter class to use prom-client internally
- Migrate Gauge class to use prom-client internally
- Migrate Histogram class to use prom-client internally
- Update getMetricsOutput() to use prom-client's native metrics()
- Update contentType() to use prom-client's contentType
- Enable collectDefaultMetrics() for Node.js system metrics
- Maintain backward compatibility with existing API

Benefits:
- Native OpenMetrics format export
- Proper histogram bucket handling
- Default Node.js metrics (memory, CPU, event loop, GC)
- Better integration with Grafana/Prometheus ecosystem
2026-01-20 12:37:17 +00:00
Claude e605a02528 fix(defaults): address PR #10 code review feedback
- Integrate RETRY_BACKOFF_DELAYS and RETRY_JITTER_FACTOR into retry-utils.ts
  - Add retryConfigs.rsocket using the default delays
  - Add getRetryDelayWithJitter() helper function
  - Add getAllRetryDelaysWithJitter() for planning
- Document DEFAULT_CACHE_MAX_KEYS with usage example
- Adjust INITIAL_PREKEY_COUNT from 30 to 200 (moderate value)
- Adjust MIN_UPLOAD_INTERVAL from 60s to 10s (balance rate limiting/responsiveness)
- Revert syncFullHistory to true (avoid breaking change)
2026-01-20 12:36:52 +00:00
Claude 6f75e5ac21 feat(socket): add configurable maxListeners to prevent memory leaks
Based on RSocket's battle-tested configuration:

- Add maxWebSocketListeners config option (default: 20)
  - 8 base WS events + 10 dynamic listeners + 2 buffer slots
- Add maxSocketClientListeners config option (default: 50)
- Replace dangerous setMaxListeners(0) with configurable limits
- Add warning log if user explicitly sets limit to 0

BREAKING: Previous behavior used setMaxListeners(0) which removed
all limits. Now defaults to safe limits but can be overridden via config.
2026-01-20 12:36:51 +00:00
Claude 682b62acbf feat(defaults): apply RSocket's battle-tested configurations
- Add DEFAULT_CACHE_MAX_KEYS with limits per store type (prevents memory leaks)
- Add RETRY_BACKOFF_DELAYS [1s, 2s, 5s, 10s, 20s] for exponential backoff
- Add RETRY_JITTER_FACTOR (0.15) to prevent thundering herd
- Change INITIAL_PREKEY_COUNT from 812 to 30 (safer for rate limiting)
- Change MIN_UPLOAD_INTERVAL from 5s to 60s (avoids rate limiting)
- Change syncFullHistory default to false (conservative approach)

Based on RSocket fork's production-tested configuration.
2026-01-20 12:36:51 +00:00