Claude
eed8c45f80
## Summary Fixed all 5 vulnerabilities identified in deep L3 security audit of PR #136: - #2 (HIGH): Incorrect JID cleanup for hosted domains - #4 (MEDIUM-HIGH): Circular dependency resolution - #5 (MEDIUM): Race condition in startup cleanup - #1 (MEDIUM): Broken test interfaces - #3 (LOW): Retry logic documentation (verified) ## Changes ### 1. Fixed Hosted JID Domain Detection (#2 - HIGH) **File:** src/Utils/decode-wa-message.ts - Fixed domain detection logic to handle @hosted and @hosted.lid JIDs correctly - Previous logic would delete wrong sessions for hosted domains - Now properly maps: lid→lid, hosted.lid→hosted.lid, hosted→hosted, s.whatsapp.net→s.whatsapp.net ### 2. Resolved Circular Dependency (#4 - MEDIUM-HIGH) **Files:** Multiple - Created src/Types/SessionCleanup.ts to hold SessionCleanupConfig interface - Removed import of DEFAULT_SESSION_CLEANUP_CONFIG from decode-wa-message.ts - Added autoCleanCorrupted parameter to decryptMessageNode function - Propagated config through SocketConfig → messages-recv.ts → decryptMessageNode - Reduced circular dependencies from 18 to 15 (-16.7%) ### 3. Fixed Race Condition in Startup Cleanup (#5 - MEDIUM) **File:** src/Signal/session-cleanup.ts - Added startupCleanupPromise tracking variable - Scheduled cleanup now waits for startup cleanup to complete - Prevents simultaneous execution of cleanup operations ### 4. Fixed Test Interface Contracts (#1 - MEDIUM) **File:** src/__tests__/Signal/session-cleanup.test.ts - Added missing cleanupOnStartup and autoCleanCorrupted properties to all test configs - Fixed 15 TypeScript compilation errors in tests ### 5. Verified Retry Documentation (#3 - LOW) **File:** src/Utils/retry-utils.ts - Confirmed retry logic is already excellently documented - Includes backoff strategies, max delay caps, jitter, circuit breaker integration ## Impact - ✅ All 5 vulnerabilities resolved - ✅ TypeScript errors in modified files: 0 - ✅ Circular dependencies reduced: 18 → 15 - ✅ Type safety maintained throughout - ✅ Backward compatibility preserved - ✅ No new race conditions or memory leaks ## Testing - TypeScript compilation: ✅ All modified files compile cleanly - Circular dependency check: ✅ Reduced from 18 to 15 cycles - Interface contracts: ✅ All tests now type-check correctly https://claude.ai/code/session_01SoNUGBEWbJwWWws3F2fuzh
27 lines
545 B
TypeScript
27 lines
545 B
TypeScript
/**
|
|
* Session cleanup configuration
|
|
*/
|
|
export interface SessionCleanupConfig {
|
|
enabled: boolean
|
|
intervalMs: number
|
|
cleanupHour: number
|
|
secondaryDeviceInactiveDays: number
|
|
primaryDeviceInactiveDays: number
|
|
lidOrphanHours: number
|
|
cleanupOnStartup: boolean
|
|
autoCleanCorrupted: boolean
|
|
}
|
|
|
|
/**
|
|
* Session cleanup statistics
|
|
*/
|
|
export interface SessionCleanupStats {
|
|
totalScanned: number
|
|
secondaryDevicesDeleted: number
|
|
primaryDevicesDeleted: number
|
|
lidOrphansDeleted: number
|
|
totalDeleted: number
|
|
durationMs: number
|
|
errors: number
|
|
}
|