Addresses bot review on commit 4bdcd5769d:
1) [Major — CodeRabbit + Copilot] `injectE2ESession` was the last
session-mutating path still locking on raw `jid` while writing through
`storeSession()` (which canonicalizes via `resolveLIDSignalAddress`). Same
PN/LID lock-vs-storage drift as the original bug — fixed by computing
`wireAddr` once and locking on it (same pattern as encrypt/decrypt).
2) [Minor — Copilot] `resolveLIDSignalAddress` docstring described the input
as `userDomain.device` but the actual format from
`jidToSignalProtocolAddress` is `signalUser.device`, where `signalUser` is
either the bare user (WhatsApp domain) or `user_domainType` for LID/hosted.
Updated to match.
3) [Minor — Copilot] `Missing device ID` error fired when the user portion
(before the `.`) was empty, which was misleading. Split into two specific
errors and added validation for the empty-device-portion case (e.g.
trailing `.`). Each now points at the actual missing part.
4) [Doc — CodeRabbit residual race concern] Added a paragraph explaining the
theoretical race between our `wireAddr` resolution and storage's internal
re-resolution if `lidMapping` mutates between the two awaits. In production
this is mitigated by the `migrateSession()` call upstream in
`messages-recv.ts` running synchronously BEFORE `decryptMessage`, so the
mapping is populated by the time the lock is acquired. Eliminating the
residual entirely requires storage to skip re-resolution — bigger refactor
reserved for a follow-up if the residual ever bites in prod.
5) [Out of scope — Copilot PR-metadata staleness] PR title still says "raw
JID" from the original commit. Will be retitled on the GitHub side after
this lands.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Renato Alcara
6c09b14776