2 Commits

Author	SHA1	Message	Date
Claude	4a3d8e9e46	fix: address PR review comments for identity change handler ... Fixes 4 issues identified in PR #35 code review: ## 1. Self-Primary Identity Check (Copilot #1) - BEFORE: `ctx.meId && (areJidsSameUser(...) || (ctx.meLid && ...))` - AFTER: Check meId and meLid independently with OR - FIX: Now correctly detects when only meLid exists ## 2. Debounce Cache Placement (Copilot #3, #4) - BEFORE: Cache set immediately after debounce check - AFTER: Cache set only before actual assertSessions call - FIX: Prevents incorrect debouncing when exiting early (offline, etc.) ## 3. Session Regression (ChatGPT Codex P2) - BEFORE: Returned 'skipped_no_session' when no session exists - AFTER: Always call assertSessions - identity change IS the signal to rebuild - FIX: Critical for key reset and device restore scenarios ## 4. Result Type Enhancement - Added `hadExistingSession: boolean` to 'session_refreshed' result - Removed 'skipped_no_session' action (no longer applicable) - Enables better monitoring of session creation vs refresh ## Test Updates - Added test for meLid-only self-primary detection - Updated session creation test (no longer skips) - Added test verifying debounce not set on offline skip - Added Result Types test suite for type safety	2026-01-22 18:55:01 +00:00
Claude	c4da46321f	feat: add identity change handler for improved connection stability ... Cherry-pick from upstream PR #2264 (commit 5cbad317) with enhancements: ## Changes ### New Files - `src/Utils/identity-change-handler.ts`: Centralized identity change handling - Enterprise-grade JSDoc documentation - Clear result types for all 9 possible outcomes - Debouncing to prevent duplicate session refreshes - Companion device filtering - Offline notification handling - `src/__tests__/Socket/identity-change-handling.test.ts`: Comprehensive tests - Core functionality tests - Debounce behavior tests - Error handling tests - Edge case coverage ### Modified Files - `src/Socket/messages-recv.ts`: Updated error handling - MISSING_KEYS_ERROR now returns NACK with ParsingError - Maintains CTWA recovery logic intact - Preserves all Prometheus metrics integration - `src/Utils/generics.ts`: Added `isStringNullOrEmpty()` helper - `src/Utils/index.ts`: Added identity-change-handler export ## Benefits - Fixes "Online" status shown when actually disconnected (#2132) - Better session management after contact identity changes - Clear separation of concerns with dedicated handler module Co-authored-by: João Lucas de Oliveira Lopes <55464917+jlucaso1@users.noreply.github.com>	2026-01-22 18:34:19 +00:00