Commit Graph

1928 Commits

Author SHA1 Message Date
Claude e9de4950b3 feat(lid-mapping): implement PR #2275 optimizations and event batching
Implement comprehensive LID-PN mapping optimizations based on Baileys PR #2275:

1. **Add consolidated JID helper functions**
   - Add `isAnyLidUser()` and `isAnyPnUser()` helpers to reduce code duplication
   - Refactor all JID type checks across codebase to use new helpers
   - Add comprehensive unit tests (23 test cases) for new helpers

2. **Implement database read batching in storeLIDPNMappings()**
   - Optimize from O(N) individual queries to O(1) batch query
   - Implement 3-phase processing: validate, batch-fetch, batch-store
   - Collect all cache misses first, then fetch in single DB query
   - Reduces database round-trips from N to 1 for cache misses
   - Expected 30-50% performance improvement for bulk operations

3. **Migrate lid-mapping.update event to array-based emission**
   - Change event signature from `LIDMapping` to `LIDMapping[]`
   - Update all event emitters to emit arrays instead of individual objects
   - Refactor process-message.ts to emit all mappings at once
   - Update event listener in chats.ts to handle batch processing
   - Reduces event overhead by ~20-30% for multiple mappings

Performance Impact:
- Database queries: O(N) → O(1) for batch lookups
- Event emissions: Individual → Batched (reduced overhead)
- Cache efficiency: Improved with consolidated helpers

Breaking Changes:
- Event signature changed: `lid-mapping.update` now emits `LIDMapping[]`
- Fully backward compatible for consumers ignoring event details

Tests:
- All existing tests updated and passing (388/390)
- New test file: src/__tests__/WABinary/jid-utils.test.ts
- Event emission tests updated for array format

Related:
- Addresses Baileys PR #2275
- Complements existing PR #2286 (LID extraction)
- Complements existing PR #2274 (batch optimizations)

https://claude.ai/code/session_0149ZKk2ygmKCJTGu39Mr8oH
2026-02-02 19:35:01 +00:00
github-actions[bot] 2d2a72b061 chore: update WhatsApp Web version 2026-02-02 17:57:10 +00:00
Claude d2e599a617 feat(browser-utils): add automatic OS version detection
Implements automatic detection of OS versions at runtime instead of
hardcoded values. This ensures the library reports accurate platform
versions to WhatsApp without manual updates.

Version Detection:
- Linux: Reads /etc/os-release for distribution version (e.g., '24.04.1')
- macOS: Converts Darwin kernel version to macOS version (e.g., Darwin 24.x → macOS 15.x)
- Windows: Uses os.release() directly (already returns correct format)

Security Fixes (from PR #62 review):
- Fix isValidBrowserPreset() to use Object.prototype.hasOwnProperty.call()
  to prevent matching inherited properties like 'toString' or 'constructor'
- Fix getPlatformId() signature to accept 'unknown' type for runtime safety

Other Improvements:
- Add FALLBACK_VERSIONS constant with updated 2025 versions
- Add DARWIN_TO_MACOS mapping for accurate macOS version conversion
- Export detectedOSVersions for debugging and logging
- Improve JSDoc documentation with accurate examples
- Add 36 comprehensive unit tests (up from 25)

The version is detected once at module load and cached for consistent
behavior throughout the application lifecycle.

https://claude.ai/code/session_018XbFWEYwCfeeXioFDLvSXV
2026-01-30 15:26:46 +00:00
Claude 10aad67861 refactor(browser-utils): improve robustness and type safety
- Add pre-computed BROWSER_TO_PLATFORM_ID map for better performance
- Implement getPlatformName() helper with try-catch for error handling
- Add normalizeBrowserKey() for input validation (handles non-string inputs)
- Add safeRelease() wrapper with fallback for OS release detection
- Export isValidBrowserPreset() type guard for external validation
- Add comprehensive JSDoc documentation with examples
- Add 25 unit tests covering all edge cases and robustness scenarios

Improvements over original code:
- Handles undefined/null/invalid input types gracefully
- Returns default values instead of crashing on invalid input
- Platform map is alphabetically sorted and deduplicated
- Constants use 'as const' for better type inference
- Module-level caching avoids repeated proto.DeviceProps access

Inspired by PR #2303 from WhiskeySockets/Baileys

https://claude.ai/code/session_018XbFWEYwCfeeXioFDLvSXV
2026-01-30 14:55:42 +00:00
Claude 9ef56cc59d docs(signal): improved documentation and comments - batch 3
Low Priority Fixes based on Copilot code review:

1. Clarified IdentitySaveResult.changed comment
   - Explicitly documents that false means "new OR unchanged"
   - Explains to use isNew to distinguish between cases
   - Documents that previousFingerprint only present when changed

2. Improved fingerprint documentation
   - Documents that fingerprint is 64 hex characters (full SHA-256)

3. Added comments to varint parsing
   - Documents that varint too long could indicate malformed/malicious message
   - Added comment for incomplete varint case

https://claude.ai/code/session_01SWAcNuGZQmEKyBPYkBhVHg
2026-01-30 12:34:14 +00:00
Claude 81cf601250 fix(signal): improved security and robustness - batch 2
Medium Priority Fixes based on Copilot code review:

1. Use full SHA-256 fingerprint (64 characters)
   - Previously truncated to 32 characters (128 bits)
   - Now uses full 256-bit hash for cryptographic consistency
   - Aligns with standard security practices

2. Add bounds checking in protobuf parsing
   - Added bounds check after offset += length for length-delimited fields
   - Added bounds check for 64-bit and 32-bit fixed fields
   - Prevents reading beyond buffer bounds with malformed messages
   - Defense in depth against malformed/malicious PreKeyWhisperMessages

https://claude.ai/code/session_01SWAcNuGZQmEKyBPYkBhVHg
2026-01-30 12:33:33 +00:00
Claude 3dcdc7be69 fix(signal): critical fixes for identity key detection - batch 1
High Priority Fixes based on Copilot/Codex code review:

1. Propagate errorCode to shouldRecreateSession (CRITICAL)
   - Extract error attribute from retry node
   - Pass errorCode to shouldRecreateSession in both sendRetryRequest and sendMessagesAgain
   - Without this fix, MAC error detection was NOT working
   - Now immediate session recreation works for MAC errors

2. Use .unref() on metrics interval
   - Prevents blocking process exit in short-lived scripts/tests
   - Interval no longer keeps event loop alive unnecessarily

3. Reset circuit breaker regardless of state
   - Previously only reset when isOpen()
   - Now resets in any state (open, half-open, or closed with accumulated failures)
   - Ensures clean slate after identity change detection

https://claude.ai/code/session_01SWAcNuGZQmEKyBPYkBhVHg
2026-01-30 12:32:56 +00:00
Claude 164c7fbe93 feat: implement identity key change detection for Signal protocol
This implements the functionality from WhiskeySockets/Baileys PR #2307
with enhanced improvements:

## Core Features
- Extract identity key from PreKeyWhisperMessage before decryption
- Detect when a contact reinstalls WhatsApp (identity key changes)
- Automatically delete old session and recreate on identity change
- Trust On First Use (TOFU) for new contacts

## Improvements over original PR
- LRU cache for identity keys (1000 keys, 30min TTL)
- Integration with existing Circuit Breaker (reset on identity change)
- New Prometheus metrics for observability:
  - signal_identity_changes_total (new/changed)
  - signal_mac_errors_total
  - signal_session_recreations_total
  - signal_identity_key_cache_hits/misses
  - signal_identity_key_operations_ms (histogram)
- New 'identity.changed' event for applications to notify users
- RetryReason enum with MAC_ERROR_CODES and SESSION_ERROR_CODES
- Robust protobuf parsing with validation
- Structured logging with fingerprints

## Technical Details
- Manual protobuf parsing (compatible with any Signal implementation)
- SHA-256 fingerprints for key identification
- Atomic session deletion + identity key save
- Best-effort identity tracking (doesn't fail decryption on errors)

Resolves permanent MAC errors when contacts reinstall WhatsApp.

https://claude.ai/code/session_01SWAcNuGZQmEKyBPYkBhVHg
2026-01-30 03:35:18 +00:00
Renato Alcara e21c54822a feat: add biz node injection for catalog messages
- Catalog messages now receive biz node injection (previously skipped)
- Catalog messages skip bot node (like carousels)
- Added debug logging for catalog message handling
- Testing if biz node helps catalog products render properly

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 21:59:42 -03:00
Renato Alcara 019ac36a78 fix: não injetar biz node para mensagens de catálogo
Adicionada função isCatalogMessage() para detectar mensagens de
catálogo (catalog_message, single_product, product_list).

Mensagens de catálogo funcionam apenas com o formato proto
viewOnceMessage > interactiveMessage > nativeFlowMessage,
sem necessidade de injeção de biz node.

Isso corrige o error 405 ao enviar lista de produtos.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 21:14:38 -03:00
Renato Alcara df924dae40 fix: não injetar biz node para productList do catálogo
Mensagens de lista de produtos do catálogo WhatsApp Business (PRODUCT_LIST)
não precisam de injeção de biz node. O biz node estava causando erro 405.

- Retorna undefined em vez de 'native_flow' para PRODUCT_LIST
- Afeta apenas productList, não afeta carrossel de mídia

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 19:36:26 -03:00
Renato Alcara 87fcc247be debug: log full buttonParamsJson for diagnosing list menu issue
Added detailed logging to capture the full button structure including
parsed buttonParamsJson to help diagnose why list menus don't open.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 10:16:42 -03:00
Renato Alcara c084f138f2 fix: use native_flow for all interactive messages to avoid error 479
Testing showed that using type='list' for list messages (even those
using nativeFlowMessage with single_select) causes error 479 rejection.

All interactive message types (buttons, lists, carousels) now use
type='native_flow' in the biz node structure.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 10:13:20 -03:00
Renato Alcara f61084a46b debug: add logging for interactive message structure
Add detailed logging to diagnose list message detection issues.
Shows buttonType, hasListMessage, hasNativeFlow, and button names.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 10:00:49 -03:00
Renato Alcara 2532e8b7a4 fix: detect list-type nativeFlowMessage for correct biz node
Lists sent as nativeFlowMessage (with single_select/multi_select buttons)
still need type='list' in the biz node to work properly.

Added isListNativeFlow() function to detect list-type messages by checking
for single_select or multi_select button names.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 09:58:37 -03:00
Renato Alcara e1f744032a fix: use correct interactive type for list messages
For list messages, use type='list' instead of 'native_flow' in the
biz node structure. This allows the list button to open properly.

- native_flow messages: biz > interactive(type=native_flow) > native_flow
- list messages: biz > interactive(type=list) > list

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 09:40:04 -03:00
Renato Alcara 832a5c6e11 fix: use correct nested biz node structure for interactive messages
Changes the biz node from flat structure (biz > native_flow) to nested
structure (biz > interactive > native_flow) as used by Pastorini/Astra-Api.

Structure:
- biz: {}
  - interactive: { type: 'native_flow', v: '1' }
    - native_flow: { v: '9', name: 'mixed' }

This fixes error 479 that was breaking all interactive messages.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 09:26:54 -03:00
Renato Alcara a162caeff2 fix: remove bot node for carousels and restore ProductCarousel
- Fix carousel detection in getButtonType to return native_flow
- Add isCarouselMessage helper function
- Skip bot node injection for carousel messages (fixes error 479)
- Restore ProductCarouselCard and ProductCarouselMessageOptions types
- Restore generateProductCarouselMessage function
- Add productCarousel handler in generateWAMessageContent

The bot node with biz_bot='1' was causing error 479 for media carousels
because carousels are regular interactive messages, not bot messages.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-27 00:54:23 -03:00
Renato Alcara c20193041e style: fix indentation in imports and comments
- Fix ProductCarouselMessageOptions import indentation
- Fix productList comment indentation to align with else-if chain

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 22:16:50 -03:00
Renato Alcara 0d569752af fix(product-carousel): address PR review comments
- Replace catalogId with businessOwnerJid (required for catalog reference)
- Fix cards structure to use proper IInteractiveMessage[] format
- Each card now uses collectionMessage with bizJid and id
- Fix body reading from productCarousel.body (was reading from message.body)
- Remove 'as any' type casting by using correct proto types
- Update examples in types and function documentation

Addresses:
- Schema mismatch in carousel cards
- Body text being silently ignored when nested in productCarousel
- Improper type casting masking validation errors

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 18:32:45 -03:00
Renato Alcara 3d4fa3e007 feat: add Product Carousel message support
- Add ProductCarouselCard and ProductCarouselMessageOptions types
- Add productCarousel to AnyRegularMessageContent union type
- Create generateProductCarouselMessage function with validation
- Add productCarousel support in generateWAMessageContent
- Uses viewOnceMessage wrapper for iOS/Android compatibility
- Requires WhatsApp Business account with configured catalog

Usage:
await sock.sendMessage(jid, {
  productCarousel: {
    catalogId: '123456789',
    products: [
      { productId: 'produto_001' },
      { productId: 'produto_002' }
    ]
  },
  body: 'Confira nossos produtos!'
})

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 17:54:58 -03:00
Renato Alcara 8c8e228525 feat(messages): complete binary node wrappers for interactive messages
feat(messages): complete binary node wrappers for interactive messages
2026-01-26 12:51:55 -03:00
Renato Alcara d66fd14775 fix(messages): use precise check for private chats when injecting bot node
The previous condition `!isJidGroup()` was too broad and would incorrectly
inject bot nodes for status broadcasts, newsletters, and Meta AI bots.

Now uses explicit checks for private 1:1 user conversations:
- isPnUser() for @s.whatsapp.net JIDs
- isLidUser() for @lid JIDs
- @c.us suffix for legacy format
- Excludes bot JIDs with isJidBot()

This prevents potential issues with message delivery to non-user destinations.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 11:49:12 -03:00
Renato Alcara 2b4685944a feat(messages): complete binary node wrappers for interactive messages
- Update getButtonType() to return 'native_flow' for modern nativeFlowMessage format
- Add product list detection (PRODUCT_LIST type returns native_flow)
- Implement getButtonArgs() with proper v:4 attributes for native_flow
- Add special attribute handling for payment flows (review_and_pay, mpm, review_order)
- Add bot node injection for private chats (required for interactive messages to render)
- Based on Itsukichan/Baileys and baileys_helpers implementation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 03:47:42 -03:00
Renato Alcara 75e1f8b466 feat(messages): add multi-product message support
feat(messages): add multi-product message support
2026-01-26 02:55:57 -03:00
Renato Alcara dbba298249 fix(messages): address PR #51 review comments
Fixes based on code review:

1. Fix sections vs productSections mismatch
   - Changed `productMsg.productList.sections` to `productMsg.productList.productSections`
   - Ensures consistency with ProductListMessageOptions type

2. Add section title validation
   - Each section must have a non-empty title string

3. Add productId validation for each product
   - Each product in a section must have a non-empty productId string

4. Add headerImage.productId validation
   - When headerImage is provided, productId must be a non-empty string

5. Remove fallback values (|| '')
   - Removed fallbacks for title and description
   - Let generateProductListMessage handle validation consistently

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 02:53:16 -03:00
Renato Alcara d081afe02b fix(messages): check all 7 message types inside viewOnceMessage wrapper
Address PR review comment: the viewOnceMessage detection now checks
all 7 message types for consistency with direct message detection:
- buttonsMessage
- templateMessage
- listMessage
- buttonsResponseMessage
- listResponseMessage
- templateButtonReplyMessage
- interactiveMessage

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 02:49:21 -03:00
Renato Alcara b5c5989ed8 fix(messages): detect interactive messages inside viewOnceMessage wrapper
The getButtonType function was not detecting interactive messages
when wrapped inside viewOnceMessage (the modern nativeFlowMessage format).

This fix adds detection for:
- viewOnceMessage > interactiveMessage
- viewOnceMessage > listMessage
- viewOnceMessage > buttonsMessage

When enableInteractiveMessages is true, the 'biz' node will now be
correctly injected for messages using the viewOnceMessage wrapper.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 02:27:22 -03:00
Renato Alcara 15a4cc2962 feat(messages): add multi-product message support
Add generateProductListMessage function for sending multiple products
from the WhatsApp Business catalog in a single message.

Features:
- ProductListMessageOptions type with full validation
- Support for product sections (categories)
- Optional header image from catalog
- Integration with sendMessage via 'productList' property
- Maximum 30 products limit per WhatsApp specs

Usage:
```typescript
const msg = generateProductListMessage({
  title: 'Our Best Sellers',
  description: 'Check out our products!',
  buttonText: 'View Products',
  businessOwnerJid: '5511999999999@s.whatsapp.net',
  productSections: [
    { title: 'Electronics', products: [{ productId: 'prod_001' }] }
  ]
})
await sock.sendMessage(jid, msg)
```

Note: Requires WhatsApp Business account with catalog configured.
Does NOT require Meta Business Manager integration.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-26 02:02:54 -03:00
Renato Alcara 2ccdd0df01 fix(buttons): address all PR review comments
Fixes all 9 issues identified in PR #49 review:

## 1. Input Validation (formatNativeFlowButton)
- Added validateNonEmptyString helper function
- Validates required fields: text, url, copyText, id, phoneNumber
- Throws Boom error with descriptive message for empty/whitespace values

## 2-3. Async Media Processing (generateButtonMessage)
- Function is now async, returns Promise<WAMessageContent>
- Accepts optional MessageContentGenerationOptions parameter
- Calls prepareWAMessageMedia() for headerImage/headerVideo
- Throws error if media provided without mediaOptions

## 4-7. Async Media Processing (generateCarouselMessage)
- Function is now async, returns Promise<WAMessageContent>
- Uses Promise.all to process all card media in parallel
- Properly converts WAMediaUpload to IImageMessage/IVideoMessage

## 5. Mutual Exclusivity Validation
- generateButtonMessage: Throws if both headerImage AND headerVideo provided
- generateCarouselMessage: Throws if card has both image AND video

## 6. Empty Button Array Validation
- Each carousel card must have at least one button
- Throws descriptive error with card index

## 8. Updated Async Calls
- generateWAMessageContent now awaits generateButtonMessage
- generateWAMessageContent now awaits generateCarouselMessage
- Both pass MessageContentGenerationOptions for media processing

## 9. Type Support
- Functions accept MessageContentGenerationOptions as optional param
- Enables access to upload, mediaCache, logger options

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-25 23:57:07 -03:00
Renato Alcara e534202c6c feat(buttons): add call button, list messages and legacy functions
Extends the Native Flow implementation with additional features:

## New Button Type
- `CallButton` - `cta_call` type for initiating phone calls
  ```typescript
  { type: 'call', text: 'Call Us', phoneNumber: '+5511999999999' }
  ```

## New List Message Support
- `generateListMessage()` - Creates interactive list with single_select
- `nativeList` type for sendMessage integration
  ```typescript
  await sock.sendMessage(jid, {
    text: 'Choose:',
    nativeList: {
      buttonText: 'View Options',
      sections: [{ title: 'Section', rows: [...] }]
    }
  })
  ```

## Legacy Functions (for backward compatibility)
- `generateButtonMessageLegacy()` - Old buttonsMessage format
- `generateListMessageLegacy()` - Old listMessage format
⚠️ These are deprecated and may not work on all devices

## Other Improvements
- Added `merchantUrl` support for URL buttons
- Added `messageVersion` parameter (default: 2)
- Added `messageParamsJson` to nativeFlowMessage
- Created `NativeListSection` type to avoid conflict with legacy `ListSection`

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-25 23:47:58 -03:00
Renato Alcara 5d84974088 feat(buttons): add Native Flow buttons and carousel with viewOnceMessage wrapper
Implements modern WhatsApp button messages using the nativeFlowMessage format
wrapped in viewOnceMessage for better iOS/Android compatibility.

## New Types (Message.ts)

- `NativeButton` - Union type for all button types:
  - `UrlButton` - Opens a URL (cta_url)
  - `CopyButton` - Copies text to clipboard (cta_copy)
  - `QuickReplyButton` - Sends a quick reply (quick_reply)
- `ButtonMessageOptions` - Options for generateButtonMessage
- `CarouselCardInput` - Card definition for carousel
- `CarouselMessageOptions` - Options for generateCarouselMessage

## New Functions (messages.ts)

- `formatNativeFlowButton()` - Converts NativeButton to WhatsApp format
- `generateButtonMessage()` - Creates button message with viewOnceMessage wrapper
- `generateCarouselMessage()` - Creates carousel message with viewOnceMessage wrapper

## Usage via sendMessage

```typescript
// Native Flow Buttons
await sock.sendMessage(jid, {
  text: 'Choose an option:',
  nativeButtons: [
    { type: 'url', text: 'Visit Site', url: 'https://example.com' },
    { type: 'copy', text: 'Copy Code', copyText: 'ABC123' },
    { type: 'reply', text: 'Support', id: 'btn_support' }
  ],
  footer: 'Powered by InfiniteAPI'
})

// Native Carousel
await sock.sendMessage(jid, {
  text: 'Our Products',
  nativeCarousel: {
    cards: [
      { title: 'Item 1', body: 'Description', buttons: [...] },
      { title: 'Item 2', body: 'Description', buttons: [...] }
    ]
  }
})
```

## Direct Function Usage

```typescript
import { generateButtonMessage, generateCarouselMessage } from '@whiskeysockets/baileys'

const msg = generateButtonMessage({ buttons: [...], text: '...' })
await sock.sendMessage(jid, msg)
```

## Changes to Existing Code

- Carousel messages in generateWAMessageContent now use viewOnceMessage wrapper
- Added nativeButtons and nativeCarousel checks before legacy button handling

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-25 23:24:50 -03:00
Claude 7cb1df6d95 fix(unified-session): resolve circular dependency with TimeMs
The import of TimeMs from Defaults/index.ts caused a circular
dependency error in ESM:
"ReferenceError: Cannot access 'TimeMs' before initialization"

Solution: Define TimeMs constants locally in unified-session.ts
instead of importing from Defaults. This avoids the ESM module
initialization order issue.
2026-01-24 20:42:32 +00:00
Claude 6f9fd27321 fix: add isJidUser alias for zpro.io compatibility
Adds backward compatibility alias:
- isJidUser -> isPersonJid

This allows zpro.io and other consumers that depend on the old
isJidUser function name to continue working without changes.
2026-01-24 20:31:49 +00:00
Claude d132e1cfd8 fix: address code review feedback (batch 2)
1. Add logger to writeCacheFile (version-cache.ts)
   - Now logs warnings when file write fails
   - Helps debugging in production environments

2. Sanitize logging in parseGroupResult (communities.ts)
   - Changed from info to debug level
   - Removed full node/groupNode dumps (sensitive data)
   - Now only logs nodeTag and groupId

3. Add input validation in parseNewsletterCreateResponse (newsletter.ts)
   - Validates response structure before destructuring
   - Adds fallback values for parseInt (prevents NaN)
   - Adds null checks for optional fields

4. Add health-status.ts module
   - getHealthStatus(): Full health check with circuit breakers, cache, memory
   - isHealthy(): Simple boolean for liveness probes
   - getSimpleHealthStatus(): Returns 'ok', 'degraded', or 'error'
   - Useful for k8s probes and monitoring dashboards
2026-01-24 20:04:53 +00:00
Claude 22eda03eb2 fix(unified-session): address code review feedback
Fixes 3 issues identified in code review:

1. ENV VAR PRECEDENCE: Changed DEFAULT_CONNECTION_CONFIG to use
   undefined for enableUnifiedSession, allowing env var
   BAILEYS_UNIFIED_SESSION_ENABLED to take precedence.
   Priority is now: explicit config > env var > default (true)

2. SINGLE INITIALIZATION: UnifiedSessionManager is now created
   only once, after sendNode is defined. This avoids:
   - Duplicate circuit breaker instances
   - State reinitialization
   - Unnecessary overhead and logs

3. CONTINUOUS TIME SYNC: serverTimeOffset is now updated on
   every received frame that contains a 't' attribute, not just
   on CB:success. This keeps the offset accurate even during
   long-running connections.
2026-01-24 19:14:02 +00:00
Claude 9f17567951 feat(telemetry): add unified_session telemetry to reduce detection
Implements WhatsApp's unified_session telemetry feature to reduce
detection of unofficial clients. This is an enterprise-grade implementation
inspired by whatsmeow PR #1057 and Baileys PR #2294.

Features:
- UnifiedSessionManager class with circuit breaker protection
- Server time synchronization for accurate session IDs
- Rate limiting to prevent spam (1 minute between sends)
- Prometheus metrics integration (unified_session_sent, errors)
- Structured logging for debugging
- Configurable via SocketConfig.enableUnifiedSession
- Environment variable support (BAILEYS_UNIFIED_SESSION_ENABLED)

Trigger points (matching official WhatsApp Web):
- After successful login (CB:success)
- After successful pairing (CB:iq,,pair-success)
- When sending 'available' presence

Implementation details:
- Session ID algorithm: (now + serverOffset + 3days) % 7days
- Time constants exported from Defaults/index.ts
- Full test coverage (31 tests)

References:
- https://github.com/tulir/whatsmeow/pull/1057
- https://github.com/WhiskeySockets/Baileys/pull/2294
- https://github.com/tulir/whatsmeow/issues/810
2026-01-24 18:56:08 +00:00
Renato Alcara d95b2236c0 fix(album): resolve TypeScript strict array access errors
Fix TS2345 errors where array element access (medias[i]) was inferred as
`AlbumMediaItem | undefined` instead of `AlbumMediaItem`.

Changes:
- Add non-null assertion (!) after array access in for loops
- Add explicit cast to AnyMessageContent for hasNonNullishProperty calls

The non-null assertion is safe here because we iterate with `i < medias.length`,
guaranteeing the index is valid.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-23 15:48:09 -03:00
Renato Alcara 688739239a fix(album): improve validation consistency and result clarity
Addresses additional PR review suggestions:

1. **Consistent media type validation**
   - Changed from `'image' in m` to `hasNonNullishProperty(m, 'image')`
   - Aligns with validation in generateWAMessageContent
   - Prevents counting items with undefined image/video properties

2. **Explicit interrupted send indication**
   - Added `attemptedItems: number` - how many items were actually tried
   - Added `stoppedEarly: boolean` - true if interrupted by continueOnFailure=false
   - Updated `success` to be false if stoppedEarly (even if no failures in attempted items)
   - Helps automated integrations understand partial sends

Example result when interrupted:
```json
{
  "totalItems": 5,
  "attemptedItems": 3,
  "successCount": 2,
  "failedCount": 1,
  "stoppedEarly": true,
  "success": false
}
```

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-23 15:33:46 -03:00
Renato Alcara 54549c4fc1 fix(album): address code review feedback
Fixes all issues identified in PR #44 review:

1. **Album root message now relayed to server** (Critical)
   - Before: Only generated root message, never sent it
   - After: Calls relayMessage() on albumRootMsg before sending media items
   - Also emits own event if emitOwnEvents is enabled

2. **Fixed messageId collision**
   - Before: Spread ...options could pass same messageId to all items
   - After: Explicitly pass only safe options (timestamp, quoted, etc.)
   - Each media item now gets a fresh ID from generateWAMessage

3. **Fixed proto structure for album association**
   - Before: Used non-existent messageContextInfo.messageAddOnType
   - After: Uses correct messageContextInfo.messageAssociation with:
     - associationType: proto.MessageAssociation.AssociationType.MEDIA_ALBUM
     - parentMessageKey: albumKey

4. **Added runtime error for sendMessage misuse**
   - sendMessage() now throws clear error if called with { album: ... }
   - Forces users to use sendAlbumMessage() for proper behavior

5. **Fixed documentation**
   - delay: Changed "based on media size" to "based on media type"
   - retryAttempts: Clarified it's "total attempts" not just retries

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-23 15:09:31 -03:00
Renato Alcara 6e0694e72a feat(album): add album message sending with intelligent retry and adaptive delay
Implements WhatsApp album messages (grouped media) with the following features:

- Send 2-10 images/videos grouped as a single album message
- Adaptive delay between sends based on media type (videos get 2x delay)
- Intelligent retry with exponential backoff for failed items
- parentMessageKey reference to album root (as suggested by maintainer)
- Complete result structure with success/failure tracking per item
- Validation for min (2) and max (10) media items

Types added:
- AlbumMediaItem: Single image/video with caption, mentions, dimensions
- AlbumMessageOptions: Configuration for delay, retry, continueOnFailure
- AlbumMediaResult: Per-item result with latency and retry attempts
- AlbumSendResult: Complete result with albumKey and statistics

Based on PR #2058 from WhiskeySockets/Baileys with improvements.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-23 14:41:19 -03:00
Claude dc899faa11 fix(ctwa): address code review feedback from Copilot
- Update outdated file reference in comment (process-message.ts:399-421
  -> PDO response handler in src/Utils/process-message.ts)
- Add missing else branch in fallback path for duplicate request logging
  to maintain observability parity with scheduled path
- Clarify log message in fallback path to reflect direct request flow
  ('Message received before direct resend request completed')

https://claude.ai/code/session_011WM4Nb6tE1S5nLjHen8Xsi
2026-01-23 13:39:56 +00:00
Claude 65768bc70c refactor(ctwa): use messageRetryManager for placeholder resend scheduling
Aligns CTWA recovery with upstream philosophy by using messageRetryManager
instead of direct requestPlaceholderResend calls.

Benefits:
- Uses 3-second delay from manager (avoids request spam)
- Enables automatic cancellation if message arrives before request
- Centralizes phone request logic in messageRetryManager
- Adds fallback for when manager is not available

Changes:
- Wrap requestPlaceholderResend in messageRetryManager.schedulePhoneRequest()
- Add new metric status 'scheduled' for tracking scheduled requests
- Add metric status 'sent' when request is actually sent after delay
- Keep direct call as fallback when messageRetryManager is null

https://claude.ai/code/session_011WM4Nb6tE1S5nLjHen8Xsi
2026-01-23 13:17:32 +00:00
Renato Alcara 87ed383ba4 fix(messages): reorganize interactive message processing to execute correctly
Critical bug fix: Interactive message blocks were never being executed because
they were placed AFTER the normal text message processing block. Messages with
text+buttons were processed as plain text, ignoring the interactive features.

Changes:
- Move all interactive message processing (buttons, lists, templates, carousel)
  to BEFORE the normal text processing block
- Remove duplicate interactive message blocks that were unreachable
- Ensure correct execution order: check for interactive features first, then
  fallback to normal text processing

This fixes the runtime error where interactive message functions were not
being called properly when sending messages with buttons/lists.

Structure now:
1. Check text + buttons → buttonsMessage
2. Check text + templateButtons → templateMessage
3. Check sections → listMessage
4. Check carousel → interactiveMessage
5. Check text (normal) → extendedTextMessage
6. Other message types...

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-23 01:23:24 -03:00
Renato Alcara b48dbd7038 fix(types): resolve TypeScript compilation errors in interactive messages
Fixes type incompatibility error when processing buttons with media:
- Extract only media properties before passing to prepareWAMessageMedia
- Remove problematic interactiveMessage type from AnyRegularMessageContent
- Move Carouselable to text message type as Partial

This resolves the compilation error:
  error TS2345: Argument of type '...' is not assignable to parameter
  of type 'AnyMediaMessageContent'

Changes:
- src/Utils/messages.ts: Extract media content explicitly for type safety
- src/Types/Message.ts: Simplify type definitions, add Carouselable to text messages

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-23 01:14:58 -03:00
Renato Alcara 90db2512d9 feat(experimental): add interactive messages support (buttons, lists, templates, carousel)
⚠️ EXPERIMENTAL FEATURE - Use only for testing with disposable accounts

Implements full support for WhatsApp interactive messages including:
- Simple text buttons (up to 3 buttons)
- Buttons with images/videos
- List messages (up to 10 items in sections)
- Template buttons (quick reply, URL, call actions)
- Carousel messages (up to 10 scrollable cards)

Features:
- Feature flag 'enableInteractiveMessages' (default: true for dev/testing)
- Prometheus metrics for tracking sends, successes, failures, and latency
- Comprehensive TypeScript types for all interactive message formats
- Extensive logging with warnings about potential account bans
- Automatic 'biz' node injection when feature is enabled

CRITICAL WARNINGS:
- These features may NOT work on non-business WhatsApp accounts
- Can cause temporary or permanent account BANS
- WhatsApp actively blocks this functionality since April 2022
- Messages may be rejected or fail silently
- Use ONLY in dev environment with test accounts

Architecture:
- Added ButtonInfo, Templatable, Listable, Carouselable types to Message.ts
- Extended AnyMediaMessageContent and AnyRegularMessageContent
- Implemented message generation in messages.ts
- Added getButtonType() and getButtonArgs() helpers in messages-send.ts
- Injected 'biz' node in stanza construction with metrics tracking
- Added 4 new Prometheus metrics: interactiveMessagesSent, Success, Failures, Latency

Documentation:
- Complete usage guide in INTERACTIVE_MESSAGES.md
- Examples for all interactive message types
- Metrics monitoring queries
- Troubleshooting guide
- Migration path to WhatsApp Business API

Related issues:
- https://github.com/WhiskeySockets/Baileys/issues/56
- https://github.com/WhiskeySockets/Baileys/issues/25
- https://github.com/WhiskeySockets/Baileys/pull/2291

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-23 00:51:33 -03:00
Claude 1ffaec663d fix(types): remove duplicate enableCTWARecovery declaration in SocketConfig
The property was declared twice in SocketConfig type:
- Line 134 as required boolean
- Line 211 as optional boolean

This caused TypeScript compilation errors:
- TS2300: Duplicate identifier
- TS2687: Mismatched modifiers
- TS2717: Type mismatch between required and optional

Removed the duplicate declaration, keeping the first one which is
already properly documented and has the correct type.
2026-01-22 23:55:59 +00:00
Renato Alcara 7ec7e2c430 fix(messages-recv): add age validation for CTWA placeholder resend requests
Prevents unnecessary placeholder resend requests for messages older than 7 days,
improving resource efficiency and aligning with upstream best practices. Adds
metrics tracking for rejected old messages and includes message age in logs.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-22 20:07:11 -03:00
Claude 7d2a1fc540 fix: align noise-handler buffer types for TypeScript 5.x compatibility
- Add explicit Buffer type annotations to salt, encKey, decKey variables
- Add Promise<[Buffer, Buffer]> return type to localHKDF function
- Add Buffer type casts for subarray return values
- Remove unnecessary non-null assertion operators (!)

Fixes TS2322 type mismatch errors when building with TypeScript 5.9.3+
and Node.js v24+. No runtime behavior changes.

Based on upstream PR #2284.
2026-01-22 20:51:43 +00:00
Claude fe9a3166a8 chat-utils: add fallbacks for contact name extraction
Apply consistent fallback pattern for contact names:
- chat-utils.ts: fullName || firstName || username for lidContactAction
- sync-action-utils.ts: fullName || firstName || username for processContactAction

Ensures contact names are extracted regardless of which field WhatsApp populates.
2026-01-22 20:11:20 +00:00