fix(ctwa): address code review feedback from Copilot
- Update outdated file reference in comment (process-message.ts:399-421
-> PDO response handler in src/Utils/process-message.ts)
- Add missing else branch in fallback path for duplicate request logging
to maintain observability parity with scheduled path
- Clarify log message in fallback path to reflect direct request flow
('Message received before direct resend request completed')
https://claude.ai/code/session_011WM4Nb6tE1S5nLjHen8Xsi
This commit is contained in:
@@ -1286,7 +1286,7 @@ export const makeMessagesRecvSocket = (config: SocketConfig) => {
|
|||||||
metrics.ctwaRecoveryRequests.inc({ status: 'sent' })
|
metrics.ctwaRecoveryRequests.inc({ status: 'sent' })
|
||||||
// Note: The actual message will be emitted via 'messages.upsert'
|
// Note: The actual message will be emitted via 'messages.upsert'
|
||||||
// when the PEER_DATA_OPERATION_REQUEST_RESPONSE_MESSAGE is processed
|
// when the PEER_DATA_OPERATION_REQUEST_RESPONSE_MESSAGE is processed
|
||||||
// in process-message.ts:399-421
|
// in the PDO response handler in src/Utils/process-message.ts
|
||||||
} else if (requestId === 'RESOLVED') {
|
} else if (requestId === 'RESOLVED') {
|
||||||
// Message was received while we were waiting
|
// Message was received while we were waiting
|
||||||
logger.debug(
|
logger.debug(
|
||||||
@@ -1322,9 +1322,19 @@ export const makeMessagesRecvSocket = (config: SocketConfig) => {
|
|||||||
'CTWA: Placeholder resend request sent successfully (direct)'
|
'CTWA: Placeholder resend request sent successfully (direct)'
|
||||||
)
|
)
|
||||||
} else if (requestId === 'RESOLVED') {
|
} else if (requestId === 'RESOLVED') {
|
||||||
logger.debug({ msgId }, 'CTWA: Message received during resend delay')
|
// Message arrived during the internal 2s delay in requestPlaceholderResend
|
||||||
|
logger.debug(
|
||||||
|
{ msgId },
|
||||||
|
'CTWA: Message received before direct resend request completed'
|
||||||
|
)
|
||||||
metrics.ctwaMessagesRecovered.inc()
|
metrics.ctwaMessagesRecovered.inc()
|
||||||
metrics.ctwaRecoveryLatency.observe(Date.now() - startTime)
|
metrics.ctwaRecoveryLatency.observe(Date.now() - startTime)
|
||||||
|
} else {
|
||||||
|
// Already requested (duplicate request prevented by cache)
|
||||||
|
logger.debug(
|
||||||
|
{ msgId },
|
||||||
|
'CTWA: Resend already requested, skipping duplicate (direct)'
|
||||||
|
)
|
||||||
}
|
}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
logger.warn({ error, msgId }, 'CTWA: Failed to request placeholder resend')
|
logger.warn({ error, msgId }, 'CTWA: Failed to request placeholder resend')
|
||||||
|
|||||||
Reference in New Issue
Block a user