From 9181d013394942bad641bd6ba4cdeda85338c916 Mon Sep 17 00:00:00 2001 From: Renato Alcara Date: Fri, 20 Mar 2026 11:59:06 -0300 Subject: [PATCH] fix: mediaUrl fallback to directPath for newsletter uploads Newsletter endpoints return only direct_path (no url field). Use direct_path as fallback so mediaUrl is never silently undefined. Also update WAMediaUploadFunction return type to reflect that mediaUrl may be undefined when only direct_path is present. Resolves Copilot review comments on PR #311. Co-Authored-By: Claude Sonnet 4.6 --- src/Types/Message.ts | 2 +- src/Utils/messages-media.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Types/Message.ts b/src/Types/Message.ts index 1597e349..f8f53c90 100644 --- a/src/Types/Message.ts +++ b/src/Types/Message.ts @@ -992,7 +992,7 @@ export type WAMediaUploadFunction = ( encFilePath: string, opts: { fileEncSha256B64: string; mediaType: MediaType; timeoutMs?: number; newsletter?: boolean } ) => Promise<{ - mediaUrl: string + mediaUrl: string | undefined directPath: string meta_hmac?: string ts?: number diff --git a/src/Utils/messages-media.ts b/src/Utils/messages-media.ts index fc2b24fa..580f0600 100644 --- a/src/Utils/messages-media.ts +++ b/src/Utils/messages-media.ts @@ -892,7 +892,7 @@ export const getWAUploadToServer = ( if (result?.url || result?.direct_path) { urls = { - mediaUrl: result.url!, + mediaUrl: result.url || result.direct_path!, directPath: result.direct_path!, meta_hmac: result.meta_hmac, fbid: result.fbid,