ruicesar/InfiniteAPI
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(types): remove non-null assertions in groups.ts, noise-handler.ts, messages-recv.ts (partial)

Browse Source 
- groups.ts: Replace ! assertions with ?? fallbacks for group attrs
- noise-handler.ts: Add proper validation for serverHello fields before use,
  remove all ! assertions (9 total), throw Boom errors for missing fields
- messages-recv.ts: Fix contradictory messageKey?.id! pattern (partial, more coming)

https://claude.ai/code/session_01E2cfX1N3sJgCJBTvzGazSG
This commit is contained in:
Claude
2026-02-08 23:41:19 +00:00
parent 92c51fa741
commit 8fd10c8b9b
3 changed files with 40 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Utils/noise-handler.ts
+23 -7
View File
@@ -150,7 +150,7 @@ export const makeNoiseHandler = ({
while (true) {
if (inBytes.length < 3) return
size = (inBytes[0]! << 16) | (inBytes[1]! << 8) | inBytes[2]!
size = (inBytes[0] << 16) | (inBytes[1] << 8) | inBytes[2]
if (inBytes.length < size + 3) return
@@ -180,13 +180,25 @@ export const makeNoiseHandler = ({
mixIntoKey,
finishInit,
processHandshake: ({ serverHello }: proto.HandshakeMessage, noiseKey: KeyPair) => {
authenticate(serverHello!.ephemeral!)
mixIntoKey(Curve.sharedKey(privateKey, serverHello!.ephemeral!))
if (!serverHello?.ephemeral) {
throw new Boom('Missing server hello ephemeral', { statusCode: 500 })
}
const decStaticContent = decrypt(serverHello!.static!)
if (!serverHello?.static) {
throw new Boom('Missing server hello static', { statusCode: 500 })
}
if (!serverHello?.payload) {
throw new Boom('Missing server hello payload', { statusCode: 500 })
}
authenticate(serverHello.ephemeral)
mixIntoKey(Curve.sharedKey(privateKey, serverHello.ephemeral))
const decStaticContent = decrypt(serverHello.static)
mixIntoKey(Curve.sharedKey(privateKey, decStaticContent))
const certDecoded = decrypt(serverHello!.payload!)
const certDecoded = decrypt(serverHello.payload)
const { intermediate: certIntermediate, leaf } = proto.CertChain.decode(certDecoded)
// leaf
@@ -202,7 +214,11 @@ export const makeNoiseHandler = ({
const { issuerSerial } = details
const verify = Curve.verify(details.key!, leaf.details, leaf.signature)
if (!details.key) {
throw new Boom('Missing certificate key', { statusCode: 500 })
}
const verify = Curve.verify(details.key, leaf.details, leaf.signature)
const verifyIntermediate = Curve.verify(
WA_CERT_DETAILS.PUBLIC_KEY,
@@ -223,7 +239,7 @@ export const makeNoiseHandler = ({
}
const keyEnc = encrypt(noiseKey.public)
mixIntoKey(Curve.sharedKey(noiseKey.private, serverHello!.ephemeral!))
mixIntoKey(Curve.sharedKey(noiseKey.private, serverHello.ephemeral))
return keyEnc
},