test: add comprehensive unit tests for session cleanup and activity tracking

Addresses Copilot code review feedback on PR #135 regarding missing test coverage for session cleanup and activity tracking functionality. Test Coverage: - session-cleanup.test.ts (14 test cases): - LID orphan cleanup with 24h threshold - Secondary device cleanup with 15 day threshold - Primary device cleanup with 30 day threshold - Boundary conditions (exact thresholds) - Mixed scenarios (multiple session types) - Configuration handling (custom thresholds, disabled cleanup) - Edge cases (empty sessions, null tracker) - session-activity-tracker.test.ts (20 test cases): - Activity recording to in-memory cache - Cache hits and disk fallback - Batch flushing to disk - Start/stop lifecycle management - Performance tests (1000 messages, batch operations) - Edge cases (special characters, rapid updates, disk errors) - Statistics tracking All tests passing (47 tests total for session management). https://claude.ai/code/session_01SoNUGBEWbJwWWws3F2fuzh
2026-02-10 10:00:52 +00:00
parent 0232a805ae
commit 6f91152b2a
2 changed files with 1073 additions and 0 deletions
@@ -0,0 +1,529 @@
+import { jest } from '@jest/globals'
+import P from 'pino'
+import { makeSessionCleanup } from '../../Signal/session-cleanup'
+import type { SessionActivityTracker } from '../../Signal/session-activity-tracker'
+import type { LIDMappingStore } from '../../Signal/lid-mapping'
+import type { SignalKeyStoreWithTransaction } from '../../Types'
+
+const mockKeys: jest.Mocked<SignalKeyStoreWithTransaction> = {
+	get: jest.fn<SignalKeyStoreWithTransaction['get']>() as any,
+	set: jest.fn<SignalKeyStoreWithTransaction['set']>(),
+	transaction: jest.fn<SignalKeyStoreWithTransaction['transaction']>(async (work: () => any) => await work()) as any,
+	isInTransaction: jest.fn<SignalKeyStoreWithTransaction['isInTransaction']>()
+}
+
+const mockLidMapping: jest.Mocked<Pick<LIDMappingStore, 'getPNForLID'>> = {
+	getPNForLID: jest.fn<LIDMappingStore['getPNForLID']>() as any
+}
+
+const mockActivityTracker: jest.Mocked<Pick<SessionActivityTracker, 'getAllActivities'>> = {
+	getAllActivities: jest.fn<SessionActivityTracker['getAllActivities']>() as any
+}
+
+const logger = P({ level: 'silent' })
+
+describe('SessionCleanup', () => {
+	const HOUR_MS = 3600000
+	const DAY_MS = 86400000
+
+	beforeEach(() => {
+		jest.clearAllMocks()
+	})
+
+	describe('LID Orphan Cleanup (24h threshold)', () => {
+		const config = {
+			enabled: true,
+			intervalMs: 86400000,
+			cleanupHour: 3,
+			secondaryDeviceInactiveDays: 15,
+			primaryDeviceInactiveDays: 30,
+			lidOrphanHours: 24
+		}
+
+		it('should delete LID orphan after 24h of inactivity', async () => {
+			const now = Date.now()
+			const lastActivity = now - (25 * HOUR_MS) // 25 hours ago
+
+			// Mock sessions: 1 LID orphan
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('session-data')
+			})
+
+			// Mock: No PN mapping (orphan)
+			mockLidMapping.getPNForLID.mockResolvedValue(null)
+
+			// Mock: Activity 25h ago
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['123456789@lid', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.lidOrphansDeleted).toBe(1)
+			expect(stats.totalDeleted).toBe(1)
+			expect(mockKeys.set).toHaveBeenCalledWith({
+				session: { '123456789_2.0': null }
+			})
+		})
+
+		it('should NOT delete LID orphan before 24h', async () => {
+			const now = Date.now()
+			const lastActivity = now - (23 * HOUR_MS) // 23 hours ago
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('session-data')
+			})
+
+			mockLidMapping.getPNForLID.mockResolvedValue(null)
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['123456789@lid', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.lidOrphansDeleted).toBe(0)
+			expect(stats.totalDeleted).toBe(0)
+			expect(mockKeys.set).not.toHaveBeenCalled()
+		})
+
+		it('should delete LID orphan with no activity tracking', async () => {
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('session-data')
+			})
+
+			mockLidMapping.getPNForLID.mockResolvedValue(null)
+
+			// No activity tracked
+			mockActivityTracker.getAllActivities.mockResolvedValue(new Map())
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.lidOrphansDeleted).toBe(1)
+			expect(stats.totalDeleted).toBe(1)
+		})
+
+		it('should NOT delete LID with valid PN mapping', async () => {
+			const now = Date.now()
+			const lastActivity = now - (25 * HOUR_MS)
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('session-data')
+			})
+
+			// Has PN mapping - not orphan
+			mockLidMapping.getPNForLID.mockResolvedValue('5511999999999@s.whatsapp.net')
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['123456789@lid', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.lidOrphansDeleted).toBe(0)
+			expect(stats.totalDeleted).toBe(0)
+		})
+	})
+
+	describe('Secondary Device Cleanup (15 days threshold)', () => {
+		const config = {
+			enabled: true,
+			intervalMs: 86400000,
+			cleanupHour: 3,
+			secondaryDeviceInactiveDays: 15,
+			primaryDeviceInactiveDays: 30,
+			lidOrphanHours: 24
+		}
+
+		it('should delete secondary device (Web/Desktop) after 15 days', async () => {
+			const now = Date.now()
+			const lastActivity = now - (16 * DAY_MS) // 16 days ago
+
+			// Mock: Secondary device (device ID = 1)
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'5511999999999_0.1': Buffer.from('session-data')
+			})
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['5511999999999:1@s.whatsapp.net', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.secondaryDevicesDeleted).toBe(1)
+			expect(stats.totalDeleted).toBe(1)
+		})
+
+		it('should NOT delete secondary device before 15 days', async () => {
+			const now = Date.now()
+			const lastActivity = now - (14 * DAY_MS) // 14 days ago
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'5511999999999_0.1': Buffer.from('session-data')
+			})
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['5511999999999:1@s.whatsapp.net', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.secondaryDevicesDeleted).toBe(0)
+			expect(stats.totalDeleted).toBe(0)
+		})
+
+		it('should NOT delete secondary device without activity tracking', async () => {
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'5511999999999_0.1': Buffer.from('session-data')
+			})
+
+			// No activity tracked - grace period
+			mockActivityTracker.getAllActivities.mockResolvedValue(new Map())
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.secondaryDevicesDeleted).toBe(0)
+			expect(stats.totalDeleted).toBe(0)
+		})
+	})
+
+	describe('Primary Device Cleanup (30 days threshold)', () => {
+		const config = {
+			enabled: true,
+			intervalMs: 86400000,
+			cleanupHour: 3,
+			secondaryDeviceInactiveDays: 15,
+			primaryDeviceInactiveDays: 30,
+			lidOrphanHours: 24
+		}
+
+		it('should delete primary device after 30 days', async () => {
+			const now = Date.now()
+			const lastActivity = now - (31 * DAY_MS) // 31 days ago
+
+			// Mock: Primary device (device ID = 0)
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'5511999999999_0.0': Buffer.from('session-data')
+			})
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['5511999999999@s.whatsapp.net', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.primaryDevicesDeleted).toBe(1)
+			expect(stats.totalDeleted).toBe(1)
+		})
+
+		it('should NOT delete primary device before 30 days', async () => {
+			const now = Date.now()
+			const lastActivity = now - (29 * DAY_MS) // 29 days ago
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'5511999999999_0.0': Buffer.from('session-data')
+			})
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['5511999999999@s.whatsapp.net', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.primaryDevicesDeleted).toBe(0)
+			expect(stats.totalDeleted).toBe(0)
+		})
+	})
+
+	describe('Boundary Conditions', () => {
+		const config = {
+			enabled: true,
+			intervalMs: 86400000,
+			cleanupHour: 3,
+			secondaryDeviceInactiveDays: 15,
+			primaryDeviceInactiveDays: 30,
+			lidOrphanHours: 24
+		}
+
+		it('should handle exactly 24h for LID orphan (boundary)', async () => {
+			const now = Date.now()
+			const lastActivity = now - (24 * HOUR_MS) // Exactly 24h
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('session-data')
+			})
+
+			mockLidMapping.getPNForLID.mockResolvedValue(null)
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([['123456789@lid', lastActivity]])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			// Exactly 24h should NOT delete (> threshold, not >=)
+			expect(stats.lidOrphansDeleted).toBe(0)
+		})
+
+		it('should handle empty session list', async () => {
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({})
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.totalScanned).toBe(0)
+			expect(stats.totalDeleted).toBe(0)
+		})
+
+		it('should handle null sessionActivityTracker gracefully', async () => {
+			const now = Date.now()
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('session-data')
+			})
+
+			mockLidMapping.getPNForLID.mockResolvedValue(null)
+
+			// Pass null tracker
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				null,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			// Should still work, but with no activity data
+			expect(stats.totalScanned).toBe(1)
+			// LID orphan with no activity tracking gets deleted
+			expect(stats.lidOrphansDeleted).toBe(1)
+		})
+	})
+
+	describe('Mixed Scenarios', () => {
+		const config = {
+			enabled: true,
+			intervalMs: 86400000,
+			cleanupHour: 3,
+			secondaryDeviceInactiveDays: 15,
+			primaryDeviceInactiveDays: 30,
+			lidOrphanHours: 24
+		}
+
+		it('should delete multiple sessions of different types', async () => {
+			const now = Date.now()
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('lid-orphan'),
+				'5511999999999_0.1': Buffer.from('secondary-inactive'),
+				'5511888888888_0.0': Buffer.from('primary-inactive'),
+				'5511777777777_0.0': Buffer.from('primary-active')
+			})
+
+			mockLidMapping.getPNForLID.mockImplementation(async (lid: string) => {
+				if (lid === '123456789@lid') return null // Orphan
+				return '5511999999999@s.whatsapp.net'
+			})
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([
+					['123456789@lid', now - (25 * HOUR_MS)], // LID orphan: 25h ago
+					['5511999999999:1@s.whatsapp.net', now - (16 * DAY_MS)], // Secondary: 16 days ago
+					['5511888888888@s.whatsapp.net', now - (31 * DAY_MS)], // Primary: 31 days ago
+					['5511777777777@s.whatsapp.net', now - (5 * DAY_MS)] // Primary: 5 days ago (active)
+				])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.totalScanned).toBe(4)
+			expect(stats.lidOrphansDeleted).toBe(1)
+			expect(stats.secondaryDevicesDeleted).toBe(1)
+			expect(stats.primaryDevicesDeleted).toBe(1)
+			expect(stats.totalDeleted).toBe(3)
+		})
+	})
+
+	describe('Configuration', () => {
+		it('should respect disabled cleanup', async () => {
+			const config = {
+				enabled: false,
+				intervalMs: 86400000,
+				cleanupHour: 3,
+				secondaryDeviceInactiveDays: 15,
+				primaryDeviceInactiveDays: 30,
+				lidOrphanHours: 24
+			}
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('session-data')
+			})
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				config
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.totalScanned).toBe(0)
+			expect(mockKeys.get).not.toHaveBeenCalled()
+		})
+
+		it('should respect custom thresholds', async () => {
+			const customConfig = {
+				enabled: true,
+				intervalMs: 86400000,
+				cleanupHour: 3,
+				secondaryDeviceInactiveDays: 5, // Custom: 5 days
+				primaryDeviceInactiveDays: 10, // Custom: 10 days
+				lidOrphanHours: 12 // Custom: 12 hours
+			}
+
+			const now = Date.now()
+
+			// @ts-ignore
+			mockKeys.get.mockResolvedValue({
+				'123456789_2.0': Buffer.from('lid-orphan'),
+				'5511999999999_0.1': Buffer.from('secondary')
+			})
+
+			mockLidMapping.getPNForLID.mockResolvedValue(null)
+
+			mockActivityTracker.getAllActivities.mockResolvedValue(
+				new Map([
+					['123456789@lid', now - (13 * HOUR_MS)], // 13h ago
+					['5511999999999:1@s.whatsapp.net', now - (6 * DAY_MS)] // 6 days ago
+				])
+			)
+
+			const cleanup = makeSessionCleanup(
+				mockKeys,
+				mockLidMapping as any,
+				mockActivityTracker as any,
+				logger,
+				customConfig
+			)
+
+			const stats = await cleanup.runCleanup()
+
+			expect(stats.lidOrphansDeleted).toBe(1) // 13h > 12h threshold
+			expect(stats.secondaryDevicesDeleted).toBe(1) // 6d > 5d threshold
+			expect(stats.totalDeleted).toBe(2)
+		})
+	})
+})