ruicesar/InfiniteAPI
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(types): remove non-null assertions in remaining 12 files

Browse Source 
Files fixed:
- messages-media.ts: stream/buffer guards, file path validation
- decode-wa-message.ts: message field guards, optional chaining
- version-cache.ts: narrowing after null checks
- jid-utils.ts: split result guards, user fallbacks
- communities.ts: attrs fallbacks with ?? operator
- sticker-pack.ts: response guards
- business.ts: attrs guards
- socket.ts: onClose guard, pairingCode guard, creds.me guard
- event-buffer.ts: null guards
- signal.ts: null guards
- encode.ts (WAM): id null check with continue
- upstream history.ts: conversations/pushnames null guards

All 26 files across the project are now corrected.
Total: ~248 non-null assertions replaced with proper null guards.

https://claude.ai/code/session_01E2cfX1N3sJgCJBTvzGazSG
This commit is contained in:
Claude
2026-02-09 00:32:04 +00:00
parent 7e88ddb858
commit 1c9fb86cc3
12 changed files with 215 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Socket/business.ts
+16 -4
View File
@@ -118,14 +118,18 @@ export const makeBusinessSocket = (config: SocketConfig) => {
content: [
{
tag: 'cover_photo',
attrs: { id: String(fbid), op: 'update', token: meta_hmac!, ts: String(ts) }
attrs: { id: String(fbid), op: 'update', token: meta_hmac ?? '', ts: String(ts) }
}
]
}
]
})
return fbid!
if (!fbid) {
throw new Error('Cover photo upload failed: missing fbid')
}
return fbid
}
const removeCoverPhoto = async (id: string) => {
@@ -332,7 +336,11 @@ export const makeBusinessSocket = (config: SocketConfig) => {
const productCatalogEditNode = getBinaryNodeChild(result, 'product_catalog_edit')
const productNode = getBinaryNodeChild(productCatalogEditNode, 'product')
return parseProductNode(productNode!)
if (!productNode) {
throw new Error('Product node not found in catalog edit response')
}
return parseProductNode(productNode)
}
const productCreate = async (create: ProductCreate) => {
@@ -372,7 +380,11 @@ export const makeBusinessSocket = (config: SocketConfig) => {
const productCatalogAddNode = getBinaryNodeChild(result, 'product_catalog_add')
const productNode = getBinaryNodeChild(productCatalogAddNode, 'product')
return parseProductNode(productNode!)
if (!productNode) {
throw new Error('Product node not found in catalog add response')
}
return parseProductNode(productNode)
}
const productDelete = async (productIds: string[]) => {
src/Socket/communities.ts
+17 -8
View File
@@ -100,7 +100,12 @@ export const makeCommunitiesSocket = (config: SocketConfig) => {
}
sock.ws.on('CB:ib,,dirty', async (node: BinaryNode) => {
const { attrs } = getBinaryNodeChild(node, 'dirty')!
const dirtyNode = getBinaryNodeChild(node, 'dirty')
if (!dirtyNode) {
return
}
const { attrs } = dirtyNode
if (attrs.type !== 'communities') {
return
}
@@ -353,13 +358,13 @@ export const makeCommunitiesSocket = (config: SocketConfig) => {
communityAcceptInviteV4: ev.createBufferedFunction(
async (key: string | WAMessageKey, inviteMessage: proto.Message.IGroupInviteMessage) => {
key = typeof key === 'string' ? { remoteJid: key } : key
const results = await communityQuery(inviteMessage.groupJid!, 'set', [
const results = await communityQuery(inviteMessage.groupJid ?? '', 'set', [
{
tag: 'accept',
attrs: {
code: inviteMessage.inviteCode!,
expiration: inviteMessage.inviteExpiration!.toString(),
admin: key.remoteJid!
code: inviteMessage.inviteCode ?? '',
expiration: (inviteMessage.inviteExpiration ?? 0).toString(),
admin: key.remoteJid ?? ''
}
}
])
@@ -432,7 +437,11 @@ export const makeCommunitiesSocket = (config: SocketConfig) => {
}
export const extractCommunityMetadata = (result: BinaryNode) => {
const community = getBinaryNodeChild(result, 'community')!
const community = getBinaryNodeChild(result, 'community')
if (!community) {
throw new Error('Missing community node in result')
}
const descChild = getBinaryNodeChild(community, 'description')
let desc: string | undefined
let descId: string | undefined
@@ -466,12 +475,12 @@ export const extractCommunityMetadata = (result: BinaryNode) => {
participants: getBinaryNodeChildren(community, 'participant').map(({ attrs }) => {
return {
// TODO: IMPLEMENT THE PN/LID FIELDS HERE!!
id: attrs.jid!,
id: attrs.jid ?? '',
admin: (attrs.type || null) as GroupParticipant['admin']
}
}),
ephemeralDuration: eph ? +eph : undefined,
addressingMode: getBinaryNodeChildString(community, 'addressing_mode')! as GroupMetadata['addressingMode']
addressingMode: getBinaryNodeChildString(community, 'addressing_mode') as GroupMetadata['addressingMode']
}
return metadata
}
src/Socket/socket.ts
+38 -10
View File
@@ -552,7 +552,11 @@ export const makeSocket = (config: SocketConfig) => {
})
if (sendMsg) {
sendRawMessage(sendMsg).catch(onClose!)
if (!onClose) {
throw new Error('onClose handler not initialized')
}
sendRawMessage(sendMsg).catch(onClose)
}
return result
@@ -609,8 +613,12 @@ export const makeSocket = (config: SocketConfig) => {
},
content: [{ tag: 'count', attrs: {} }]
})
const countChild = getBinaryNodeChild(result, 'count')!
return +countChild.attrs.value!
const countChild = getBinaryNodeChild(result, 'count')
if (!countChild) {
return 0
}
return +(countChild.attrs.value ?? 0)
}
// Pre-key upload state management
@@ -885,7 +893,11 @@ export const makeSocket = (config: SocketConfig) => {
return
}
const duration = Date.now() - sessionStartTime!
if (!sessionStartTime) {
return
}
const duration = Date.now() - sessionStartTime
const durationHours = Math.floor(duration / 1000 / 60 / 60)
logger.info(`🕐 Session TTL reached after ${durationHours}h, initiating graceful cleanup`)
@@ -1305,7 +1317,11 @@ export const makeSocket = (config: SocketConfig) => {
async function generatePairingKey() {
const salt = randomBytes(32)
const randomIv = randomBytes(16)
const key = await derivePairingCodeKey(authState.creds.pairingCode!, salt)
if (!authState.creds.pairingCode) {
throw new Error('Pairing code not set')
}
const key = await derivePairingCodeKey(authState.creds.pairingCode, salt)
const ciphered = aesEncryptCTR(authState.creds.pairingEphemeralKeyPair.public, key, randomIv)
return Buffer.concat([salt, randomIv, ciphered])
}
@@ -1352,7 +1368,7 @@ export const makeSocket = (config: SocketConfig) => {
attrs: {
to: S_WHATSAPP_NET,
type: 'result',
id: stanza.attrs.id!
id: stanza.attrs.id ?? ''
}
}
await sendNode(iq)
@@ -1431,7 +1447,9 @@ export const makeSocket = (config: SocketConfig) => {
logger.info('opened connection to WA')
clearTimeout(qrTimer) // will never happen in all likelyhood -- but just in case WA sends success on first try
ev.emit('creds.update', { me: { ...authState.creds.me!, lid: node.attrs.lid } })
if (authState.creds.me) {
ev.emit('creds.update', { me: { ...authState.creds.me, lid: node.attrs.lid } })
}
ev.emit('connection.update', { connection: 'open' })
@@ -1454,13 +1472,23 @@ export const makeSocket = (config: SocketConfig) => {
const myLID = node.attrs.lid
process.nextTick(async () => {
try {
const myPN = authState.creds.me!.id
const me = authState.creds.me
if (!me) {
return
}
const myPN = me.id
// Store our own LID-PN mapping
await signalRepository.lidMapping.storeLIDPNMappings([{ lid: myLID, pn: myPN }])
// Create device list for our own user (needed for bulk migration)
const { user, device } = jidDecode(myPN)!
const decoded = jidDecode(myPN)
if (!decoded) {
return
}
const { user, device } = decoded
await authState.keys.set({
'device-list': {
[user]: [device?.toString() || '0']
@@ -1548,7 +1576,7 @@ export const makeSocket = (config: SocketConfig) => {
logger.debug({ name }, 'updated pushName')
sendNode({
tag: 'presence',
attrs: { name: name! }
attrs: { name: name ?? '' }
}).catch(err => {
logger.warn({ trace: err.stack }, 'error in sending presence update on name change')
})